not sure what this means, you want to check for 0 ? == 0 would be clearer

also getEvalParams should be modified to return an int instead of a string

or do something like:

def getEvalParamsInt(...):
    ... current getEvalParams code minus stringify
def getEvalParams(...):
    i = getEvalParamsInt(...)
    return f"{i:X}"

shift = shift_from_mask if there's a mask else if there's no mask then there's no shift

could there be a comment somewhere about the difference between actorParam and params

actorParam is used for custom actors (actors with the id custom)

both are a StringProperty without get/set, it doesn't seem there needs to be two?

params use get/set

there's upgrade code but no cur_version bump anywhere?

yeaaaaahhhhhh I guess, that PR is kinda old now so I probably didn't know yet about that and end up forgetting about it

since I remembered why, cur_version doesn't exist anymore. we discussed about that a while ago and figured out checking if old props exist in a blend is stronger than a version check (idr the specifics though, iirc it was kure's idea)

so there are three sets of rotations?

• one from the blender object
• two "override", one for non-custom actors and one for custom? why are these two different? why are the properties for "Custom" named "Override"?

• blender object (which won't be used if the actor can have parameters in its rotation, which makes sense to me)
• string prop rotation for actors without the id "custom"
• string prop rotation for custom actors

iirc the override thing is gone and it all depend on the xml data, I fail to see how using rotations as real rotation and not parameter can be useful if the actor is using rotations

btw this depends on other parameters, some actors doesn't always actually check for the rotation for params, in this case the blender object rotation can be used (aka if you don't see any rotation param field in the fast64 ui)